[Webkit-unassigned] [Bug 37905] Rendering SVGs through img elements is slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37905


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53909|review?                     |review+
               Flag|                            |




--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-04-20 20:10:40 PST ---
(From update of attachment 53909)

> +    if (s.width() * s.height() < 1024*1024) {

I guess this is the why you dont pass the coding style. Space needed around the
*. That needs fixing.

> Image* cachedImage = svgAsCachedImage();

so svgAsCachedImage creates a cached representation and stores it internally?
Maybe use a better name.

Maybe you could merge the two lines:

182         Image* cachedImage = svgAsCachedImage();
 183         if (cachedImage) {

Apart from that looks good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.