[Webkit-unassigned] [Bug 37790] [DRT/Chromium] Import Chromium image_diff as ImageDiff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37790





--- Comment #9 from TAMURA, Kent <tkent at chromium.org>  2010-04-19 19:14:22 PST ---
(In reply to comment #4)
> - What is the difference between compareImages and untestedCompareImages? 
> Should we try to switch to untestedCompareImages so we can be more like the
> existing ImageDiffs?

Actually, I don't know.  ImageDiff.cpp is almost equivalent to Chromium
image_diff.cc.
The code of untestedCompareImages() has been there since the initial commit.
It's not used for now.  We may remove it.

> - Also, should we add --tolerance as a command line flag like the others?

I don't think it should be handled in this bug.

> - I guess we have to include gfx for the pngencoder, I guess that's ok.  Can we
> avoid base/basictypes.h?

It seems we don't need basictypes.h on Mac.  I'll update the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.