[Webkit-unassigned] [Bug 37790] [DRT/Chromium] Import Chromium image_diff as ImageDiff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37790





--- Comment #8 from Tony Chang (Google) <tony at chromium.org>  2010-04-19 19:07:42 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > We could use the existing ImageDiff CG on mac, since all the dependencies are
> > the same, but on Windows and Linux we would still need our own ImageDiff.
> 
> Of course, there are multiple WebKit ports on both Windows and Linux as well,
> so a similar point stands.

I don't understand what you're suggesting we do.  There are 2 ImageDiffs
checked in right now: CG and QT.  If we want to use the CG one for Windows
chromium, we would have to grab all the WebKitSupport files used by WebKit/win
(I don't think this is done by update-webkit --chromium).  If we want to use
the QT one for Linux chromium, we'd have to install a bunch of QT dev libraries
on linux (probably done manually via apt-get on the slaves and all developers).
 Are you suggesting we go this route?

I'm suggesting we just check in our own ImageDiff (the one in this patch) to
avoid these build dependencies.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.