[Webkit-unassigned] [Bug 37738] new-run-webkit-tests low timeout is too sensitive to runaway processes or test crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37738





--- Comment #6 from Eric Seidel <eric at webkit.org>  2010-04-19 02:50:33 PST ---
(In reply to comment #5)
> Sounds like a neat idea. It would somewhat reduce the incentive to make your
> tests fast though. Maybe there could be a "soft" timeout that would result in a
> non-failure warning, to make slow tests more visible?

All timeouts are currently "soft" in that all failures are re-run at the end. 
Tests which timed out once due to machine load are unlikely to time out twice.

> > Also, is there a way we can kill ReportCrash from NRWT? When I run the tests
> > locally, I frequently will "sudo killall ReportCrash" in a loop. I'd much
> > rather have NRWT do that for me. The sudo is the problem of course.
> 
> I don't think that would be a good thing to do. The crash logs are very useful
> for diagnosing what went wrong, especially on the buildbots.

I've long wanted such an option to run-webkit-tests.  It's easy enough to do.
Just requires adding a flag to DumpRenderTree to have it catch the necessary
signals and exit(1) instead of letting the OS catch them for us and calling
ReportCrash.  I don't think we'd want this mode on by default, but it would be
useful.

Even if there was just an easy way to renice ReportCrash a few times that would
make its behavior way easier to deal with.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.