[Webkit-unassigned] [Bug 37738] new-run-webkit-tests low timeout is too sensitive to runaway processes or test crashes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37738





--- Comment #5 from Maciej Stachowiak <mjs at apple.com>  2010-04-19 01:55:42 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > Why not run tests with a TIMEOUT expectation with a lower timeout?
> 
> I prefer that to the current model actually. I don't much like that we need to
> mark things as SLOW. It's confusing and complicated (mea culpa). The downside,
> which is relatively minor, is that the test may start passing with the regular
> timeout and we wouldn't know. The downside seems preferable to the confusion of
> the current model, namely, people have a lot of trouble understanding when they
> should mark something TIMEOUT vs SLOW.

Sounds like a neat idea. It would somewhat reduce the incentive to make your
tests fast though. Maybe there could be a "soft" timeout that would result in a
non-failure warning, to make slow tests more visible?

> Also, is there a way we can kill ReportCrash from NRWT? When I run the tests
> locally, I frequently will "sudo killall ReportCrash" in a loop. I'd much
> rather have NRWT do that for me. The sudo is the problem of course.

I don't think that would be a good thing to do. The crash logs are very useful
for diagnosing what went wrong, especially on the buildbots.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.