[Webkit-unassigned] [Bug 37588] Make new-run-webkit-tests work for the Qt port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37588





--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-04-14 13:21:36 PST ---
(In reply to comment #4)
> > Eventually we need to set up a self._built_bin_path for the linux ports since
> > both DumpRenderTree and ImageDiff will have this trouble.  For Qt it's "bin",
> > for Gtk its "Programs", migth as well share the code.  But we can come back and
> > do that later.
> 
> You mean something that returns the suffix ("bin", "Programs"), or the full
> path, so that both the Qt and Gtk port implementations would concat
> _build_path() and the suffix?

I had figured a _build_path replacement for the places that have more specific
needs.

like _built_bin_path("DumpRenderTree") would be the call for all ports, and on
linux ports that would make the right _build_path("bin", *components) call, but
on normal ports it would just call _build_path(*components).  Don't know. 
Hadn't written it yet.  It's not essential for this change and is somethign we
can clean up later when we have more data about our uses.

> It's not picking up custom configurations, but at least on Linux
> webkit-build-directory actually works for Debug vs Release, so hard coding to
> "Release" seems wrong in hindsight.

Sounds good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.