[Webkit-unassigned] [Bug 37588] Make new-run-webkit-tests work for the Qt port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37588





--- Comment #4 from Tor Arne Vestbø <vestbo at webkit.org>  2010-04-14 12:34:39 PST ---
(In reply to comment #2)
> (From update of attachment 53346 [details])
> Technically we use " instead of ' (or try to in our python).

Noted.

> Eventually we need to set up a self._built_bin_path for the linux ports since
> both DumpRenderTree and ImageDiff will have this trouble.  For Qt it's "bin",
> for Gtk its "Programs", migth as well share the code.  But we can come back and
> do that later.

You mean something that returns the suffix ("bin", "Programs"), or the full
path, so that both the Qt and Gtk port implementations would concat
_build_path() and the suffix?

Happy to do either as part of this patch just to make it cleaner.

> How does this detect the right configuration?  I still owe Adam Barth a patch
> to have WebKit.default_configuration read from $BUILD_DIR/Configuration instead
> of the current path hack that it does.

It's not picking up custom configurations, but at least on Linux
webkit-build-directory actually works for Debug vs Release, so hard coding to
"Release" seems wrong in hindsight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.