[Webkit-unassigned] [Bug 37566] code outside of port/factory.py should never use sys.platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37566





--- Comment #1 from Dirk Pranke <dpranke at chromium.org>  2010-04-14 11:14:36 PST ---
The original design theory of the port package was that all platform-specific
functionality was hidden below it, and the code above it would be clean. So, I
agree that code in run_webkit_tests, layout_package, etc. should not read
sys.platform.

I feel less strongly about code inside the port/ directory. I think in general
it's a good idea to avoid reading sys.platform to implement large branches in
the code, but the maintenance impact of trying to stuff every branch of the
code into separate files can make maintenance harder in some cases (i.e., I
don't think it needs to be a black and white rule).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.