[Webkit-unassigned] [Bug 37566] New: code outside of port/factory.py should never use sys.platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37566

           Summary: code outside of port/factory.py should never use
                    sys.platform
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: aroben at apple.com, abarth at webkit.org,
                    dpranke at chromium.org, cjerdonek at webkit.org


code outside of port/factory.py should never use sys.platform

% grep "sys.platform" -r *
layout_tests/layout_package/json_results_generator.py:                         
            shell=(sys.platform == 'win32'),
layout_tests/port/apache_http_server.py:        return sys.platform in
("win32", "cygwin")
layout_tests/port/base.py:        if sys.platform in ('cygwin', 'win32'):
layout_tests/port/base.py:        if sys.platform == 'win32':
layout_tests/port/chromium.py:        close_flag = sys.platform not in
('win32', 'cygwin')
layout_tests/port/chromium.py:            if sys.platform not in ('win32',
'cygwin'):
layout_tests/port/factory.py:        if sys.platform == 'win32' or sys.platform
== 'cygwin':
layout_tests/port/factory.py:        elif sys.platform == 'linux2':
layout_tests/port/factory.py:        elif sys.platform == 'darwin':
layout_tests/port/factory.py:        raise NotImplementedError('unknown port;
sys.platform = "%s"' %
layout_tests/port/factory.py:                                  sys.platform)
layout_tests/port/http_server.py:        if sys.platform == 'darwin':
layout_tests/port/http_server.py:        if sys.platform in ('cygwin',
'win32'):
layout_tests/port/http_server.py:        if sys.platform == 'win32' and
self._register_cygwin:
layout_tests/port/server_process.py:        close_fds = sys.platform not in
('win32', 'cygwin')
layout_tests/port/server_process.py:        if sys.platform not in ('win32',
'cygwin'):
layout_tests/port/websocket_server.py:        if sys.platform in ('cygwin',
'win32'):
layout_tests/port/websocket_server.py:        if sys.platform == 'win32' and
self._register_cygwin:
layout_tests/rebaseline_chromium_webkit_tests.py:    use_shell =
sys.platform.startswith('win')
layout_tests/rebaseline_chromium_webkit_tests.py:            if
sys.platform.startswith("win"):
layout_tests/run_webkit_tests.py:        while ((directory != 'http' or
sys.platform in ('darwin', 'linux2'))
layout_tests/run_webkit_tests.py:        options.use_apache = sys.platform in
('darwin', 'linux2')

Pretty much every one of those is a bug/layering violation.

I'll look at that list more this week.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.