[Webkit-unassigned] [Bug 36761] [EFL] Modify the autotools build system to add support to build the EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36761





--- Comment #17 from Xan Lopez <xan.lopez at gmail.com>  2010-04-12 21:21:04 PST ---
(In reply to comment #16)
> To make things clear so we provide a patch that works right away and not go
> through endless review cycles: Do you want something like:
> 
> GNUMakefile.am, that:
> 
> if GTK_PORT
> include GNUMakefileGtk.am
> endif
> 
> if EFL_PORT
> include GNUMakefileEfl.am
> endif

Exactly.

> 
> with all required GTK or EFL references in these specific files. There should
> be one patch refactoring Gtk, splitting it into GNUMakefile.am and
> GNUMakefileGtk.am, and then another adding GNUMakefileEfl.am and required
> includes in central makefile?

First refactoring the GTK port and then adding the EFL support would be the
ideal way to do it, yep.

> 
> Moreover, how do you like common parts? Should they be preferably initialized
> to the correct _sources _LIBADD like case 1 below, or defined as variables to
> be used like in case 2:
> 
> Case 1:
> noinst_LTLIBRARIES += libJavaScriptCore.la
> 
> Case 2:
> COMMON_NOINST_LIBS += libJavaScriptCore.la
> #and from inside port:
> noinst_LTLIBRARIES += $(COMMON_NOINST_LIBS)
> 
> I like case1 better.

Unless you somehow need to refer to the variables from the port-specific files
I don't see any reason to not do it like 1), yeah.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.