[Webkit-unassigned] [Bug 36761] [EFL] Modify the autotools build system to add support to build the EFL port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36761





--- Comment #16 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-04-12 19:02:35 PST ---
(In reply to comment #15)
> (In reply to comment #13)
> > Xan, yes this is one option. But do you want separated configure.ac as well or
> > no?
> 
> Not sure how you could make that work transparently, but in any case I don't
> think that's necessary at this point.

To make things clear so we provide a patch that works right away and not go
through endless review cycles: Do you want something like:

GNUMakefile.am, that:

if GTK_PORT
include GNUMakefileGtk.am
endif

if EFL_PORT
include GNUMakefileEfl.am
endif

with all required GTK or EFL references in these specific files. There should
be one patch refactoring Gtk, splitting it into GNUMakefile.am and
GNUMakefileGtk.am, and then another adding GNUMakefileEfl.am and required
includes in central makefile?

Moreover, how do you like common parts? Should they be preferably initialized
to the correct _sources _LIBADD like case 1 below, or defined as variables to
be used like in case 2:

Case 1:
noinst_LTLIBRARIES += libJavaScriptCore.la

Case 2:
COMMON_NOINST_LIBS += libJavaScriptCore.la
#and from inside port:
noinst_LTLIBRARIES += $(COMMON_NOINST_LIBS)

I like case1 better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.