[Webkit-unassigned] [Bug 29362] Qt build error in GraphicsContextQt.cpp (qt 4.4.0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29362


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40222|Use QColor(shadowColor)     |Use QColor(shadowColor)
        description|instead of                  |instead of
                   |QBurhs(shadowColor)         |QBrush(shadowColor)




--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-09-28 11:44:59 PDT ---
(From update of attachment 40222)
I'm confused.

http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/Color.h#L111

Transparently converts to QColor, and not to QBrush, right?  So why is an
explicit conversion necessary here?  Shouldn't operator QColor automatically be
called?  Or maybe I'm incorrect in my understanding of the QColor operator().

I still don't understand why this is necessary?  Won't the existing code
already do the right thing on either Qt 4.4 or 4.5?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.