[Webkit-unassigned] [Bug 29362] Qt build error in GraphicsContextQt.cpp (qt 4.4.0)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29362





--- Comment #9 from Fumitoshi Ukai <ukai at chromium.org>  2009-09-28 01:38:50 PDT ---
Thanks for review!

(In reply to comment #7)
> (From update of attachment 40040 [details])
> The idea is good, the implementation needs some tweak.
> 
> > +        In Qt 4.4, QBrush constructor that takes QColor was added additional
> > +        default parameter Qt::BrushStyle, so that WebCore::Color isn't
> > +        converted as QBrush implicitly.
> 
> Actually, it's more like "In Qt 4.5, a new function QPainter::fillRect(QRect,
> QColor) is introduced".
> The idea is to speed up solid color fill, because we can avoid the rather
> expensive construction of QBrush.

Ah, I see.

> 
> > -        p->fillRect(shadowRect, shadowColor);
> > +        p->fillRect(shadowRect, QBrush(shadowColor));
> 
> And therefore the right fix should be QColor(shadowColor). Otherwise, we keep
> falling back to use QBrush, thereby cancelling out the intended optimization.

Fixed to use QColor(shadowColor) instead of QBrush(shadowColor).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.