[Webkit-unassigned] [Bug 29664] [Chromium] Add initial V8 bindings for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29664


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40150|                            |review?(dglazkov at chromium.o
               Flag|                            |rg)
  Attachment #40047|0                           |1
        is obsolete|                            |




--- Comment #5 from Kenneth Russell <kbr at google.com>  2009-09-25 15:15:13 PDT ---
Created an attachment (id=40150)
 --> (https://bugs.webkit.org/attachment.cgi?id=40150)
Revised patch

Made above requested changes. Comments:

> > +        } else {
> > +            return throwError("Could not convert argument 0 to either an int32 or an array");
> > +        }
> 
> ditto.

Changed this, but I think leaving the braces off the trailing else clause is
ugly.

> > +        OwnPtr<GraphicsContext3DInternal> d;
> 
> would love a slightly more descriptive name :)

Renamed to m_internal.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.