[Webkit-unassigned] [Bug 29664] [Chromium] Add initial V8 bindings for WebGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29664


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40047|review?(dglazkov at chromium.o |review-
               Flag|rg)                         |




--- Comment #4 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2009-09-25 10:10:18 PDT ---
(From update of attachment 40047)
We're almost there!

> +        if (argLen == 0) {
> +            return throwError("No arguments specified to constructor");
> +        }

no braces for one-liners.

> +        } else {
> +            return throwError("Could not convert argument 0 to either an int32 or an array");
> +        }

ditto.

> +    if (data == NULL) {

if (!data) {

> +    if (data == NULL) {

ditto.

> +    if (data == NULL) {

ditto.

> +        OwnPtr<GraphicsContext3DInternal> d;

would love a slightly more descriptive name :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.