[Webkit-unassigned] [Bug 28868] [HTML5][Forms] :valid/:invalid/:optional/:required CSS selectors should be applied lively

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28868


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40029|                            |review?, commit-queue?
               Flag|                            |
  Attachment #39168|0                           |1
        is obsolete|                            |




--- Comment #7 from TAMURA, Kent <tkent at chromium.org>  2009-09-23 16:39:55 PDT ---
Created an attachment (id=40029)
 --> (https://bugs.webkit.org/attachment.cgi?id=40029)
Proposed patch (rev.4)


> Needs {} since the comment makes it multi-line.  There are 2 instances of that.

Fixed 2 instances, and removed {} for single statement at another place.

> If updateValue() isn't const anymore, why is this const_cast needed?
>  297     const_cast<HTMLTextAreaElement*>(this)->updateValue();

In order to nuke "const" of "this".  This method is const and updateValue() is
not const.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.