[Webkit-unassigned] [Bug 28868] [HTML5][Forms] :valid/:invalid/:optional/:required CSS selectors should be applied lively

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28868


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39168|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-09-23 10:45:27 PDT ---
(From update of attachment 39168)
Looks fine to me.  Sad this has been sitting in the queue for 2 weeks w/o
comment. :(

50     if (textArea->willValidate())
 51         // Need to sync the value in order to apply :valid/:invalid
selectors.
 52         textArea->updateValue();

Needs {} since the comment makes it multi-line.  There are 2 instances of that.

If updateValue() isn't const anymore, why is this const_cast needed?
 297     const_cast<HTMLTextAreaElement*>(this)->updateValue();

I'm not sure I'm the best person to review this change, but the others have
been silent.  It looks OK to me and looks non-harmful.  I'll r+ it, but it
can't be auto-committed as is, so you'll have to commit this yourself, find
someone to commit it, or post a new patch with modifications for the
commit-queue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.