[Webkit-unassigned] [Bug 29206] post-diff and post-commits should be able to find bug urls in ChangeLogs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29206





--- Comment #9 from Eric Seidel <eric at webkit.org>  2009-09-19 00:38:21 PDT ---
(In reply to comment #8)
> BTW bugzilla-tool still differs from commit-log-editor (see
> <http://trac.webkit.org/changeset/48503>):
> 
> - bzt does't strip spaces to the left of the commit log.
> - bzt doesn't change date/name/email lines to subdirectory names.
> - bzt puts the LayoutTest/ChangeLog entry first (not last).
> - bzt is not putting a blank line between ChangeLog entries.
> - bzt doesn't consolidate common lines from each ChangeLog entry to the top of
> the commit log.
> 
> Having said that, I don't like how commit-log-editor squishes the "WebCore:"
> headings into the first line of text after it (see
> <http://trac.webkit.org/changeset/48492> for example).
> 
> I guess I should file a bug about these differences?

Yes, this is awful.  No it's not intentional.  bzt's current behavior is simply
the easiest thing I could hack together.  I would much rather have them be
identical in behavior and share commit-log-editor code between the script and
bugzilla-tool.

Eventually we should either find a way to make bugzilla-tool call
commit-log-editor to produce the ChangeLog entry, or re-write commit-log-editor
as a python module which can be shared by both bugzilla-tool and the
script/editor-launcher-thingy.

bug 26755 already covers fixing this, but you should feel encouraged to add
more comments there and/or post patches to improve the situation. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.