[Webkit-unassigned] [Bug 29206] post-diff and post-commits should be able to find bug urls in ChangeLogs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29206





--- Comment #8 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2009-09-18 16:20:45 PDT ---
(In reply to comment #7)
> (In reply to comment #5)
> > (From update of attachment 39662 [details] [details])
> > >+         - Fallback to bug urls in commit diffs, instead of just in commit messages,
> > >+           meaning post-commits will now find bug urls in ChangeLogs.
> > 
> > Why do this?  By providing fallback behavior, we don't encourage developers to
> > put the bug number in the commit message.  (Or is this because svn doesn't have
> > the concept of a commit log within its patches?)
> 
> When I'm writing a change in Git to post to bugzilla I don't put the ChangeLog
> in teh commit log.  Only when I'm landing do I do that.  I don't use
> commit-log-editor, and perhaps that explains this habit of mine.

I realized after posting this that if people use bzt to commit (or the
commit-queue), it won't really matter, so this is really a moot point.

BTW bugzilla-tool still differs from commit-log-editor (see
<http://trac.webkit.org/changeset/48503>):

- bzt does't strip spaces to the left of the commit log.
- bzt doesn't change date/name/email lines to subdirectory names.
- bzt puts the LayoutTest/ChangeLog entry first (not last).
- bzt is not putting a blank line between ChangeLog entries.
- bzt doesn't consolidate common lines from each ChangeLog entry to the top of
the commit log.

Having said that, I don't like how commit-log-editor squishes the "WebCore:"
headings into the first line of text after it (see
<http://trac.webkit.org/changeset/48492> for example).

I guess I should file a bug about these differences?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.