[Webkit-unassigned] [Bug 29188] [Qt] Add persistence support for the "Always enable" options in the inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29188


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39690|                            |review?
               Flag|                            |
  Attachment #39638|0                           |1
        is obsolete|                            |




--- Comment #6 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2009-09-17 03:32:59 PDT ---
Created an attachment (id=39690)
 --> (https://bugs.webkit.org/attachment.cgi?id=39690)
Patch v0.3

> > +        retVal.setValue(static_cast<QString>(icSetting.string()));
> 
> Are all the manual casts from String to QString necessary? I thought we have
> automatic conversion for that.

This one is necessary since setValue is a template.
Other were to fix ambiguity operator+ error, using QLatin1String instead also
did the trick so I removed them.

Other comments have been applied in the patch, thx.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.