[Webkit-unassigned] [Bug 29188] [Qt] Add persistence support for the "Always enable" options in the inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29188


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hausmann at webkit.org




--- Comment #5 from Simon Hausmann <hausmann at webkit.org>  2009-09-16 06:32:39 PDT ---
(In reply to comment #4)
> > +    // To allow QWebInspector's configuration persistence
> > +    QCoreApplication::setOrganizationName("Trolltech");
> 
> Trolltech ceased to exist, we can't use it anymore.

I guess we could use "Nokia" instead :)

> > +    QCoreApplication::setApplicationName("QtLauncher");
> 
> > +#include <QSettings>
> 
> QtCore/QSettings, like other includes.

Hmm, we need this style of inclusion only in our public header
files (to avoid that customers have to change their .pro files),
but for the implementation I think the prefixless inclusion
is fine.

> > +static const QString SETTINGS_STORAGE_PREFIX("Qt/QtWebKit/QWebInspector/");
> > +static const QString SETTINGS_STORAGE_TYPE_SUFFIX(".type");
> 
> Since this is not a macro, no need to capital letters.
> Also use QLatin1String for string constants.

I was about to suggest a

static const char* settingsStorageSuffix[] = "..."

Either way the global variable should not be upper-cased if I interpret the
style correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.