[Webkit-unassigned] [Bug 28781] Add QWebFrame::renderElement to API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28781





--- Comment #10 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-09-16 13:24:11 PDT ---

> Do you mean ImageDiff in DumpRenderTree/qt?
> I've tried to do image compare, but it didn't really work because of
> differences in text rendering on different platforms. 
> I think ImageDiff compare with tolerance value would work. Is it possible to
> move this functionality somewhere as a library, or should I just copy/paste the
> code?

Yes, I was refering to that. Maybe you also want to default the rendering to
use the raster engine when comparing images, as we do with the DRT.
(QApplication::setGraphicsSystem("raster") <- has to be before the QApplication
is created.)

About making it a library, I'm OK with that, but I think you should discuss it
with Ariya as he is the author.

> As I understand, RenderImage is base class for the render objects, that are
> heavy on rendering/unpacking, like images or video thumbnails, so it's not
> really limited to images only.
> I'd suggest 1st comment like:
> // Optimization when the render object has a cached image.

Good! :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.