[Webkit-unassigned] [Bug 28781] Add QWebFrame::renderElement to API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28781





--- Comment #9 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2009-09-16 11:56:52 PDT ---
(In reply to comment #7)
> So I looked a bit more at the patch. Ariya added some code to the
> DumpRenderTree to compare images, maybe that is better for the auto test, than
> just comparing sizes?

Do you mean ImageDiff in DumpRenderTree/qt?
I've tried to do image compare, but it didn't really work because of
differences in text rendering on different platforms. 
I think ImageDiff compare with tolerance value would work. Is it possible to
move this functionality somewhere as a library, or should I just copy/paste the
code?

> The code looks fine, but im wondering about one thing. The cache optimization
> is only for images right?, so that makes this comment a bit confusing
> 
> +    // fall back to full rendering if no cached image
> 
> Maybe change the other comment to
> 
> // Optimization when the render object is an image and has been cached.
> 
> Then you could leave out the other comment, or write something like
> 
> // No optimization possible, fall back to normal rendering.

As I understand, RenderImage is base class for the render objects, that are
heavy on rendering/unpacking, like images or video thumbnails, so it's not
really limited to images only.
I'd suggest 1st comment like:
// Optimization when the render object has a cached image.

Thanks,
  Sl

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.