[Webkit-unassigned] [Bug 27514] add support for watched expressions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27514


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39610|review?                     |review-
               Flag|                            |




--- Comment #26 from Timothy Hatcher <timothy at hatcher.name>  2009-09-15 17:55:06 PDT ---
(From update of attachment 39610)
> +        properties.sort(rootTreeElementConstructor.prototype.comparePropertyNames);

This should just be rootTreeElementConstructor.comparePropertyNames, to allow
instances to override the prototype.

> +            if (property.name === " ") 

Maybe everywhere you check for " " you should just trim whitspace
(String.trimWhitespace in utilities.js) and look for "" or !property.name?

I would r+ this, but I would like to see the prototype thing fixed, even though
it isn't an issue today.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.