[Webkit-unassigned] [Bug 27514] add support for watched expressions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27514


Patrick Mueller <pmuellr at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39610|                            |review?
               Flag|                            |
  Attachment #39458|0                           |1
        is obsolete|                            |




--- Comment #25 from Patrick Mueller <pmuellr at yahoo.com>  2009-09-15 13:05:18 PDT ---
Created an attachment (id=39610)
 --> (https://bugs.webkit.org/attachment.cgi?id=39610)
proposed patch - 2009/09/15

All the suggested changes were made.

Additional things:

- I had to move the displaySort business around - turns out I wasn't sorting
the properties inside the expressions themselves in the WatchExpressions
correctly.  To get this to work right for all the ObjectProperty* bits, the
functionality was moved to the tree element prototype.  The sort logic itself
was unchanged.

- the callback in ObjectPropertyTreeElement.onpopulate() wasn't working
correctly, but I couldn't figure out why; changed from using the "self = this"
type of closure reference to bind(this) on the callback, which worked fine.

- had to make the ": " element in the property items a span itself, so I could
hide it during edit

- changed the edit code to use css to turn the name span into a block element
with width:100%.  Looks better.  No nbsp hacks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.