[Webkit-unassigned] [Bug 29077] [v8] Share persistent context handles between events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29077





--- Comment #10 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com>  2009-09-11 01:31:37 PDT ---
> I'm worried about how this interacts with weak handles.  For example, we lose
> 
> - m_context.makeWeak();
> 
> in V8AbstractEventListener.cpp.  That seems like it might cause problems...

Before, each OwnHandle had its own persistent handle it needed to manager.  Now
the event is sharing the handle of the frame or isolated world to which it
belongs the owner takes care of that.

> Also,
> 
> -    m_context.MakeWeak(this, &contextWeakReferenceCallback);
> +    m_context->get().MakeWeak(this, &contextWeakReferenceCallback);
> 
> in V8IsolatedWorld.cpp.  Won't that make the shared handle weak?  Doesn't
> V8Proxy need to hold a strong reference to the context?

Yes, it will make the shared handle weak.  But that's no different from how it
was before really except that before there was as many handles as there were
event listeners, all of them weak, whereas now there is just one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.