[Webkit-unassigned] [Bug 29077] [v8] Share persistent context handles between events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29077


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39413|review?                     |review-
               Flag|                            |




--- Comment #9 from Adam Barth <abarth at webkit.org>  2009-09-11 01:02:06 PDT ---
(From update of attachment 39413)
I'm worried about how this interacts with weak handles.  For example, we lose

- m_context.makeWeak();

in V8AbstractEventListener.cpp.  That seems like it might cause problems...

Also,

-    m_context.MakeWeak(this, &contextWeakReferenceCallback);
+    m_context->get().MakeWeak(this, &contextWeakReferenceCallback);

in V8IsolatedWorld.cpp.  Won't that make the shared handle weak?  Doesn't
V8Proxy need to hold a strong reference to the context?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.