[Webkit-unassigned] [Bug 29077] [v8] Share persistent context handles between events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 09:43:31 PDT 2009


--- Comment #7 from Christian Plesner Hansen <christian.plesner.hansen at gmail.com>  2009-09-10 09:43:30 PDT ---
(In reply to comment #6)
> (From update of attachment 39340 [details])
> + PassRefPtr<SharedPersistent<v8::Context> > context = proxy->shared_context();
> We don't usually hold PassRefPtrs as local variables.  They're a bit tricky to
> use like this b/c they like to null themselves out.  In this case, we're fine,
> but I wanted to make sure you're realized what you were doing was somewhat
> subtle.

No, it should have been a RefPtr.  I'd prefer to fix it even though it happens
to work here.

> +        No new tests. (OOPS!)
> This line will be rejected by the pre-submit checks.  We can either land this
> manually, or we can land it automatically if you upload a new patch without
> this line.

I'll upload a new patch with the above change and this line removed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list