[Webkit-unassigned] [Bug 29077] [v8] Share persistent context handles between events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29077


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39340|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Adam Barth <abarth at webkit.org>  2009-09-10 09:28:54 PDT ---
(From update of attachment 39340)
+ PassRefPtr<SharedPersistent<v8::Context> > context = proxy->shared_context();

We don't usually hold PassRefPtrs as local variables.  They're a bit tricky to
use like this b/c they like to null themselves out.  In this case, we're fine,
but I wanted to make sure you're realized what you were doing was somewhat
subtle.

+        No new tests. (OOPS!)

This line will be rejected by the pre-submit checks.  We can either land this
manually, or we can land it automatically if you upload a new patch without
this line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.