[Webkit-unassigned] [Bug 24289] [Qt] lacks clipToImageBuffer()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24289





--- Comment #4 from Dirk Schulze <krit at webkit.org>  2009-09-10 04:05:43 PDT ---
(In reply to comment #3)
> (From update of attachment 28174 [details])
> Just a quick review before I give it a try.
> 
> > +        [QT] lacks putImageData support in Canvas
> 
> Should be Qt.
> 
> > +    if (!m_data->countSavesDuringMasking.empty())
> 
> Let us use isEmpty() to make the code more Qt-like.
> 
> > +    QRect qrect(QRect(rect.x(), rect.y(), rect.width(), rect.height()));
> 
> Is it possible to convert FloatRect to QRectF first, then finally to QRect?
> 
> > +    TransparencyLayer * maskLayer = new TransparencyLayer(m_data->p(), qrect);
> 
> Coding style with *.
> 
> > +    p->setCompositionMode(QPainter::CompositionMode_SourceOver);
> 
> Should we save the composition mode and restore it again, instead of setting it
> to SourceOver?
> 
> > +void ImageBuffer::putImageData(ImageData* source, const IntRect& sourceRect, const IntPoint& destPoint)
> 
> I guess this is not necessary anymore because it is already implemented?

Shall I upload a new patch with the corrections of above? It doesn't work
anyway even if it should (in my understanding). But the things you pointed out
are correct. The style-issues as well as your assumptions  about putImageData
and to save the operator.
I would prefer the first patch (with fixed style issues), but qt just supports
1-Bit masks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.