[Webkit-unassigned] [Bug 24289] [Qt] lacks clipToImageBuffer()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24289





--- Comment #3 from Ariya Hidayat <ariya.hidayat at trolltech.com>  2009-09-09 19:03:29 PDT ---
(From update of attachment 28174)
Just a quick review before I give it a try.

> +        [QT] lacks putImageData support in Canvas

Should be Qt.

> +    if (!m_data->countSavesDuringMasking.empty())

Let us use isEmpty() to make the code more Qt-like.

> +    QRect qrect(QRect(rect.x(), rect.y(), rect.width(), rect.height()));

Is it possible to convert FloatRect to QRectF first, then finally to QRect?

> +    TransparencyLayer * maskLayer = new TransparencyLayer(m_data->p(), qrect);

Coding style with *.

> +    p->setCompositionMode(QPainter::CompositionMode_SourceOver);

Should we save the composition mode and restore it again, instead of setting it
to SourceOver?

> +void ImageBuffer::putImageData(ImageData* source, const IntRect& sourceRect, const IntPoint& destPoint)

I guess this is not necessary anymore because it is already implemented?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.