[Webkit-unassigned] [Bug 28806] [Qt] Make the WebInspector available as a widget class.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 01:38:39 PDT 2009


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> changed:

           What    |Removed                     |Added
  Attachment #39254|                            |review?
               Flag|                            |
  Attachment #39174|0                           |1
        is obsolete|                            |

--- Comment #5 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2009-09-09 01:38:39 PDT ---
Created an attachment (id=39254)
 --> (https://bugs.webkit.org/attachment.cgi?id=39254)
Changes v0.4

(In reply to comment #4)

> Shall we mention it simple "as QWidget" to avoid confusion?
Yes, guess so

> Do we need to add the new friend in this patch? Where is it necessary?
No, not in this patch, removed it

> "value" is a weird argument name.
Changed them

> Just to confirm: although this is a new file, part of it was taken from another
> code where Holger has his copyright?
Ah, copy/paste error. Except on this copyright line I don't think he needs

> Do we need to mention all the new functions? Probably fine with only listing
> the new source files?

> Final concern: don't we need a unit test (or even a manual test) for this?
I agree, the class is at least used in QtLauncher, but if you think of any
other way to test this, please let me know.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list