[Webkit-unassigned] [Bug 28865] [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28865





--- Comment #14 from Simon Hausmann <hausmann at webkit.org>  2009-09-08 02:40:17 PDT ---
(In reply to comment #11)
> Using DynamicPropertyChange will not work for the QWebGraphicsItem so far, as
> the platformWidget returned is the QGraphicsView viewport (the last one who
> sent a event to the page), thus setCursor will work, but the
> DynamicPropertyChange will not.
> 
> So, I don't like this change unless we fix the platformWidget not to return who
> sent events, but the actual QWebPage wrapper (QWebView or QGraphicsView) - thus
> a QObject and not a QWidget.
> 
> I do not know if this is really desirable.

I agree it won't work if the property is always set on the QWidget that
platformWidget() returns. We _want_ to set the property on the visual wrapper
around QWebPage, which can be either a QWebView (what platformWidget() returns)
or the QWebGraphicsItem. The latter is also a QObject and therefore supports
dynamic properties. We just need to somehow make WidgetQt::setCursor operate on
a QObject instead of a QWidget for it to work with the graphics item. And of
course we need to map it to QGraphicsItem's setCursor/unsetCursor :)

I believe in WebCore/manual-tests there's a few tests (.html files) that allow
testing the custom cursors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.