[Webkit-unassigned] [Bug 28865] [Qt] Make cursor set cleaner in QtWebKit Api: eliminate SetCursorEvent hack.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28865





--- Comment #13 from Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>  2009-09-07 15:54:13 PDT ---

> hum , i see your concern. can not we install an event filter to
> qgraphicsview->viewport() and make the thing to happen there ?
> 
> kenneth, if simon does not agree w/ this patch as well, please feel free to
> un-obsolete the previous one and ignore my name in patch-by fields.

As far as I understood it, it was a good suggestions from Simon's side, making
it a bit easier for us, knowing when WebCore set the cursor and when it was set
by the user.

Adding an eventfilter is really a bad workaround and I would avoid that at all
costs. As you know from your old eventfilter patch, it is currently not
possible to get notified by Qt when a scene gets / looses a view, and thus
adding the eventfilter doesn't always work as expected as it depends on the
call order of the app using QWebGraphicsItem.

I believe that it is right for the platformWidget to return the last widget who
sent events to the QWebPage, as pointed out by Simon, as it is always used to
act on events.

Maybe we need a way to get the QWebPage  or its view (QWebView or
QWebGraphicsItem - QWidget or QGraphicsWidget) from within Widget in a similar
way to get the platformWidget.

I think we can commit the first patch as it is, and then make a bug report for
the remaining improvements/issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.