[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27651


Jakub Wieczorek <faw217 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #39110|                            |review?
               Flag|                            |
  Attachment #34653|0                           |1
        is obsolete|                            |




--- Comment #46 from Jakub Wieczorek <faw217 at gmail.com>  2009-09-05 04:53:23 PDT ---
Created an attachment (id=39110)
 --> (https://bugs.webkit.org/attachment.cgi?id=39110)
Remove the private classes from QWebPluginDatabase.

(In reply to comment #42)
> (From update of attachment 34653 [details])
> Jakub, the patch looks great to me, except for one _tiny_ buglet. I'll r+ it if
> you
> could leave the d pointers in there. Add the m_plugin, m_database, etc.
> members, that's
> great. But keep the (forward declared) d-pointers, too, even if they're unused.
> _If_ 
> something goes wrong we can still extend with the d-pointer and keep binary
> compatibility.
> 
> Sorry :)

No problem, I agree with that.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.