[Webkit-unassigned] [Bug 27651] [Qt] QWebPluginDatabase API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27651





--- Comment #45 from Simon Hausmann <hausmann at webkit.org>  2009-09-03 12:19:34 PDT ---
(In reply to comment #33)
> (From update of attachment 33894 [details])
> This seems OK.  Maybe it should be called normalizePathForComparison if it's
> only for comparison.  It's unclear what "normalize" should actually do?  Does
> it resolve symlinks?  Does it remove traililing '/' chars?  Does it return the
> ~1 windows form of paths?  r- for more explanation and or a better name...
> 
> In general I'm in favor of the concept though.  Another way would be to to just
> have a arePathsEqual function. :)

I admit I prefer a function that does one thing, normalize a path by for
example removing redundant pieces. arePathsEqual does two things, normalize and
then compare. Unless the other operating systems have one function for both I
can imagine that all the FileSystemXXX.cpp implementations are going to add an
internal function to normalize and then do a string comparision :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.