[Webkit-unassigned] [Bug 28901] strnstr in wtf/StringExtras.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28901





--- Comment #4 from Fumitoshi Ukai <ukai at chromium.org>  2009-09-02 00:34:21 PDT ---
Thanks for the review

(In reply to comment #2)
> (From update of attachment 38912 [details])
> > +    return NULL;
> 
> Should be 0, not NULL.
> 
> Is this new code, or did you take it from somewhere? The implementation in
> <http://www.opensource.apple.com/source/Libc/Libc-583/string/FreeBSD/strnstr.c>
> looks quite different, but I do not know if any of the differences are
> practical.

This is new code. Should we use FreeBSD implementation?
I'm slightly worried about copyright issue (FreeBSD one has advertise clause).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.