[Webkit-unassigned] [Bug 28901] strnstr in wtf/StringExtras.h

Wed Sep 2 00:30:09 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=28901

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38912|review?                     |review-
               Flag|                            |

--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-09-02 00:30:08 PDT ---
(From update of attachment 38912)
I would have used longer names for the variables.  Just because this is a POSIX
method doesn't mean we have to use old c-style naming conventions. ;)

r-, but not for the naming nit, rather for the nits above from ap. :)

Thanks for the patch!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.