[Webkit-unassigned] [Bug 30674] Failed on test case: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm

Fri Oct 30 14:04:05 PDT 2009

https://bugs.webkit.org/show_bug.cgi?id=30674

Chang Shu <Chang.Shu at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1

--- Comment #3 from Chang Shu <Chang.Shu at nokia.com>  2009-10-30 14:04:05 PDT ---
(In reply to comment #2)
> (From update of attachment 42222 [details])
> This only patches the Qt-specific code path, not the normal
> platform-independent one. It’s also not the best practice to post a patch
> knowingly leaving out the test you plan to make. It creates more work for
> reviewers who have to review it twice even if there’s nothing wrong with it.
> It’s better engineering to write the test before the bug fix -- you need to
> make sure it fails without the code change.

Thanks very much for the comments. I will take care of the test cases soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.