[Webkit-unassigned] [Bug 30674] Failed on test case: http://www.w3.org/Style/CSS/Test/CSS2.1/current/html4/t0511-c21-pseud-link-02-e.htm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 30 12:23:01 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30674


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42222|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2009-10-30 12:23:01 PDT ---
(From update of attachment 42222)
This only patches the Qt-specific code path, not the normal
platform-independent one. It’s also not the best practice to post a patch
knowingly leaving out the test you plan to make. It creates more work for
reviewers who have to review it twice even if there’s nothing wrong with it.
It’s better engineering to write the test before the bug fix -- you need to
make sure it fails without the code change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list