[Webkit-unassigned] [Bug 30773] [Qt] QWebInspector: improve QWebPage::webInspectorTriggered(QWebElement&) -> QWebInspector::show() connection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30773





--- Comment #4 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2009-10-29 11:22:19 PDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > I also like requested more than triggered.
> 
> It's actually triggered, ie it's not a request you can ignore and then nothing
> will happen. I think that's why we went for triggered.
> 

I think that what makes us feel that its triggered is the inspection that
happen "magically".
If QWebPage have no direct effect on the inspector beside through this signal's
emission, I agree that it feels more like a request than a trigger.


Take for example if we have two signals/connections instead of one which
connects to the QWebInspector:
QWPage::webInspectorShowRequested() ==> QWInspector::show()
QWPage::inspectElementRequested(QWE&) ==>
QWInspector::setInspectedElement(QWE&)


Having one signal connected to both slots might also make sense, still no
magic:
QWebPage::webInspectorRequested(QWE&) ==> QWebInspector::show()
QWebPage::webInspectorRequested(QWE&) ==>
QWebInspector::setInspectedElement(QWE&)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.