[Webkit-unassigned] [Bug 30773] [Qt] QWebInspector: improve QWebPage::webInspectorTriggered(QWebElement&) -> QWebInspector::show() connection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30773





--- Comment #3 from Tor Arne Vestbø <vestbo at webkit.org>  2009-10-28 11:20:35 PDT ---
(In reply to comment #2)
> No need for web either... we have methods like history() returning QWebHistory.
> page() returning QWebPage etc.

I agree with you in general, but in this specific case the "Web Inspector" is a
name on its own: http://webkit.org/blog/41/introducing-the-web-inspector/

> I also like requested more than triggered.

It's actually triggered, ie it's not a request you can ignore and then nothing
will happen. I think that's why we went for triggered.

> For setInspectedElement(), I would just go for inspectElement().

That changes the semantics of the function. It's a property setter, not a
function that does something (shows the view, highlights, etc). It would not
match the getter inspectedElement() either.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.