[Webkit-unassigned] [Bug 30823] New: Fix alpha handling when using wxWidgets 2.9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30823

           Summary: Fix alpha handling when using wxWidgets 2.9
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit wx
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: vz-webkit at zeitlins.org



Vadim Zeitlin <vz-webkit at zeitlins.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41955|                            |review?, commit-queue?
               Flag|                            |


Created an attachment (id=41955)
 --> (https://bugs.webkit.org/attachment.cgi?id=41955)
Patch fixing alpha transparency handling for wx port

Transparency in PNG images didn't work in wxWebKit because the wxBitmap "has
alpha" internal flag was not set before wxGraphicsBitmap was created from it.
This flag is set in wxPixelData dtor and, generally speaking, bitmap data can't
be accessed at all while it is locked for the raw access via wxPixelData so we
must ensure that the local "data" variable is destroyed before using bitmap in
any way.

This patch does just this: in spite of many apparent changes it simply adds a
block around "data" variable to ensure that it is destroyed (this should be
more clear if the patch is applied and "diff -b" is done).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.