[Webkit-unassigned] [Bug 30822] New: Change NativeImagePtr definition for wx port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30822

           Summary: Change NativeImagePtr definition for wx port
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Minor
          Priority: P4
         Component: WebKit wx
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: vz-webkit at zeitlins.org



Vadim Zeitlin <vz-webkit at zeitlins.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41954|                            |review?
               Flag|                            |


Created an attachment (id=41954)
 --> (https://bugs.webkit.org/attachment.cgi?id=41954)
Patch changing NativeImagePtr definition for wx port

This patch changes NativeImagePtr definition from a pointer to
wx[Graphics]Bitmap to just the object itself for wx port. The reason for doing
this is that these classes are already smart pointer-like in wx and it just
doesn't make sense to have another layer of indirection and extra heap
allocations when using them -- they're supposed to be passed around by value.

I didn't try to build any other ports after this change but I hope to not
having broken them as the definitions of the types didn't change for them so
the existing code should continue to work and the changes to common,
port-independent, parts were tested as part of wxWebKit rebuild.

Finally, this is, of course, hardly a critical issue and it does have some
drawbacks: for one, I don't know if making a type with "Ptr" name not a pointer
is acceptable. Second, the common code should take care to use
"NativeImagePtr()" instead of "NULL" when initializing invalid native image
objects and use the new "IsValidNativeImagePtr()" function for testing them
instead of just comparing with "NULL" (although the latter can still be done in
port-specific code for ports other than wx, of course). But I still hope this
patch can be applied because allocating these objects on the heap is just
unnecessary and the code doing it is painful to read.

TIA!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.