[Webkit-unassigned] [Bug 28239] bugzilla-tool land-patches rejects patches from the commit-queue when not in --commit-queue mode

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 16:37:22 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=28239





--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-10-23 16:37:22 PDT ---
I'm not sure which circumstances produce this bug, making it difficult to fix. 
Should patches not be cq-'d when a build fails and you're not in commit mode? 
If not, we just need to conditionalize:

        except ScriptError, e:
            # Mark the patch as commit-queue- and comment in the bug.
            tool.bugs.reject_patch_from_commit_queue(patch['id'],
e.message_with_output())
            error(e)

in LandPatchesFromBugs.land_patches

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list