[Webkit-unassigned] [Bug 30631] Suppress unavoidable MSVC warnings during wxWebKit build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30631


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-10-23 14:07:47 PDT ---
(In reply to comment #2)
> Please let me know if you'd [still] like me to open bugs for 4244 and/or 4291.
> Also, should I open bugs for other, more serious (IMO), warnings which this
> patch does not suppress?

You should open bugs for any issues you feel are serious.  Your discretion.

> > If you want this committed by the commit-bot you'll need to set commit-queue=?
> 
> Thanks, I'll do it after updating the patch to mention the new bug numbers (if
> any). BTW, is there any convention for referring to the bugs in WebKit sources,
> e.g. "#NNNN" or "bug NNNN"? Sorry if this is answered elsewhere but I didn't
> find it in http://webkit.org/coding/contributing.html and couldn't find any
> references to the existing bugs in the sources neither.

We normally just use the full url in source code.  Like:
https://bugs.webkit.org/show_bug.cgi?id=30631

If you want a patch cq+'d it will need to be r+'d as well, so if you post a new
patch make sure to mark it both r? and cq?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.