[Webkit-unassigned] [Bug 30631] Suppress unavoidable MSVC warnings during wxWebKit build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30631





--- Comment #2 from Vadim Zeitlin <vz-webkit at zeitlins.org>  2009-10-22 10:10:57 PDT ---
(In reply to comment #1)
> (From update of attachment 41564 [details])

Thanks for your quick review!

> I'm glad to see these documented.  We're slowly getting rid of the struct/class
> warnings.

I had a patch correcting 3-4 of them and I probably could still find it (I
dropped the branch but it must be in reflog yet) if you think this could be
useful. FWIW it's probably not the most useful warning in the world, I can't
imagine it indicating any _real_ problems.

> Are you sure the rest of these should not be turned into bugs?

I think the only one which could be worth fixing is C4244: "conversion from
'xxx' to 'yyy', possible loss of data". Unfortunately there are probably
thousands of occurrences of this warning in WebKit (just as in any non-trivial
C++ program because of implicit conversions inherited from C) so I don't know
if it's realistic to hope to ever fix it.

I also reviewed a couple of occurrences of C4291 and I think it's safe to
ignore it in this case. I didn't check all of them though.

The rest are either useless or can't be fixed anyhow.

> Please strongly consider turning some of these into WebKit bugs and adding the bug numbers to the settting.py comments as well.

Please let me know if you'd [still] like me to open bugs for 4244 and/or 4291.
Also, should I open bugs for other, more serious (IMO), warnings which this
patch does not suppress?

> If you want this committed by the commit-bot you'll need to set commit-queue=?

Thanks, I'll do it after updating the patch to mention the new bug numbers (if
any). BTW, is there any convention for referring to the bugs in WebKit sources,
e.g. "#NNNN" or "bug NNNN"? Sorry if this is answered elsewhere but I didn't
find it in http://webkit.org/coding/contributing.html and couldn't find any
references to the existing bugs in the sources neither.

TIA!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.