[Webkit-unassigned] [Bug 30520] Enable creation of custom SidebarTreeElements for different ProfileTypes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 17:04:25 PDT 2009


https://bugs.webkit.org/show_bug.cgi?id=30520





--- Comment #8 from Timothy Hatcher <timothy at hatcher.name>  2009-10-20 17:04:25 PDT ---
(In reply to comment #7)
> (From update of attachment 41493 [details])
> > +    // Must be implemented by subclasses.
> > +    createView: function(profile)
> 
> Nit, can be done in subsequent patch: usually abstract methods that are
> implemented in concrete classes are named as doCreateSomething*.
> Otherwise it is easy to get confused on what should be overriden and what not.

This is not something we normally do in WebKit. I think the normal names are
better.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list