[Webkit-unassigned] [Bug 30520] Enable creation of custom SidebarTreeElements for different ProfileTypes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30520


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41493|review?                     |review-
               Flag|                            |




--- Comment #7 from Pavel Feldman <pfeldman at chromium.org>  2009-10-20 15:47:13 PDT ---
(From update of attachment 41493)
> +    // Must be implemented by subclasses.
> +    createView: function(profile)

Nit, can be done in subsequent patch: usually abstract methods that are
implemented in concrete classes are named as doCreateSomething*.
Otherwise it is easy to get confused on what should be overriden and what not.

> +    {
> +        throw new Error("Needs implemented.");
> +    },

"Not implemented" ?

>  
> +        profile._type = profileType;

This looks like a hack: what if concrete profile object already has this
property?
Either declare it a hack and name it "__profilesPanelProfileType" or make
profile define "type" getter and put it into docs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.