[Webkit-unassigned] [Bug 30485] Web Inspector: Properties on Arrays and NodeLists are not logged correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 18 18:37:22 PDT 2009


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
  Attachment #41389|review?                     |review+
               Flag|                            |

--- Comment #6 from Timothy Hatcher <timothy at hatcher.name>  2009-10-18 18:37:22 PDT ---
(From update of attachment 41389)

> +console-format.html:15["test", "test2", undefined, undefined, "test4"]

It would be nice to have a space or ": " seperator here. Like the CONSOLE
MESSAGE version.

> -function dumpMessages()
> +window.dumpMessages = function(testController)

These are equivlant. If it is a global function, I prefer the old version.

> +        for (var i = 0; i < messages.length; ++i)

Why < here? I think < would work fine.

> +            result.push(messages[i].toMessageElement().textContent);

Does this need .replace(/\u200b/g, "")?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list